BewareMyPower commented on a change in pull request #8244:
URL: https://github.com/apache/pulsar/pull/8244#discussion_r506914289



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
##########
@@ -72,6 +84,13 @@ public static void main(String[] args) throws 
InterruptedException {
 
         ZooKeeper localZk = initZk(arguments.zookeeper, 
arguments.zkSessionTimeoutMillis);
 
+        if (arguments.bkMetadataServiceUri != null) {
+            BookKeeper bookKeeper = new BookKeeper(new 
ClientConfiguration().setMetadataServiceUri(arguments.bkMetadataServiceUri));

Review comment:
       IMO, it's better to be consistent with the project. The Pulsar project 
uses the old API currently which can be verified by running
   
   ```bash
   find . -name "*.java" | xargs grep -n "import .*\.BookKeeper"
   ```
   in the project directory.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to