jonyhy96 commented on a change in pull request #360:
URL: https://github.com/apache/pulsar-client-go/pull/360#discussion_r508956246



##########
File path: pulsar/producer.go
##########
@@ -138,6 +138,9 @@ type ProducerOptions struct {
 
        // A chain of interceptors, These interceptors will be called at some 
points defined in ProducerInterceptor interface
        Interceptors ProducerInterceptors
+
+       // MaxReconnectToBroker set the maximum retry number of 
reconnectToBroker. (default: no retry)
+       MaxReconnectToBroker int

Review comment:
       > @jonyhy96 Sorry for the reply later, i think we should reset this pull 
request to the original commit for backward compatibility.
   
   Already reset this pr to original commit.
   By the way, the go.mod file seems a little bit dirty,you can reproduce this 
by run comamnd `go mod tidy` locally.
   
   ```shell
   ➜  pulsar-client-go git:(feat-max-reconnect-to-broker) go mod tidy -v        
   unused github.com/modern-go/concurrent
   unused github.com/modern-go/reflect2
   ```
   
   perhaps add script below to ci for check if go.mod has been commit correctly
   
   ```shell
   go mod tidy
   git diff --exit-code -- go.mod go.sum
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to