bschofield commented on a change in pull request #8325:
URL: https://github.com/apache/pulsar/pull/8325#discussion_r510322142
##########
File path: pulsar-client-go/pulsar/c_producer.go
##########
@@ -298,6 +298,7 @@ func pulsarProducerSendCallbackProxyWithMsgID(res
C.pulsar_result, messageId *C.
sendCallback.callback(getMessageId(messageId), newError(res,
"Failed to send message"))
} else {
sendCallback.callback(getMessageId(messageId), nil)
+ C.pulsar_message_id_free(messageId)
Review comment:
You're absolutely right. I didn't even think to check that getter for
side effects. Removed in latest commit. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
