codelipenghui commented on a change in pull request #8318:
URL: https://github.com/apache/pulsar/pull/8318#discussion_r511481913
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
##########
@@ -368,6 +372,7 @@ public void acknowledgeMessage(List<Position> positions,
AckType ackType, Map<St
}
if
(!cursor.getMarkDeletedPosition().equals(previousMarkDeletePosition)) {
+ deleteTransactionMarker((PositionImpl)
cursor.getMarkDeletedPosition(), ackType, properties);
Review comment:
The mark delete position of the cursor may be modified, it's better to
avoid to all `cursor.getMarkDeletedPosition()` twice, it might return a
different position. So you can use a local variable to maintain the
currentMarkDeletePosition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
