cbornet commented on pull request #6720: URL: https://github.com/apache/pulsar/pull/6720#issuecomment-723421991
I have rebased the PR and tested it with KoP and AoP. KoP built and tested fine. For AoP, there's a small incompatibility in `Consumer::sendMessages` signature because the `ChannelPromise` is replaced by `CompletableFuture<Void>`. I can change the signature to return a Netty `Future<Void>` and it would keep compatibility but it would keep a dependency on Netty which feels wrong and unnecessary : the callers of `sendMessage` only check the completion of the Future. It's a small change in AoP to return a `CompletableFuture<Void>` and once I did it on my clone, AoP built and tested OK. So @Sijie, what do you prefer ? Should I keep `ChannelPromise` compatibility or is it OK to replace by `CompletableFuture<Void>` (considering AoP 0.1.0 is very young and still in rc) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
