jiazhai commented on a change in pull request #8472:
URL: https://github.com/apache/pulsar/pull/8472#discussion_r520293927



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
##########
@@ -595,6 +595,9 @@ public NamespaceIsolationData getNamespaceIsolationPolicy(
                             brokerIsolationData.namespaceRegex = 
Lists.newArrayList();
                         }
                         
brokerIsolationData.namespaceRegex.addAll(policyData.namespaces);
+                        if (nsPolicyImpl.isPrimaryBroker(broker)) {
+                            brokerIsolationData.isPrimary = true;
+                        }

Review comment:
       Oh, I see, there is no such an area for `isSecondary`
   ```
   public class BrokerNamespaceIsolationData {
   
       @ApiModelProperty(
           name = "brokerName",
           value = "The broker name",
           example = "broker1:8080"
       )
       public String brokerName;
       @ApiModelProperty(
               name = "policyName",
               value = "Policy name",
               example = "my-policy"
           )
       public String policyName;
       @ApiModelProperty(
               name = "isPrimary",
               value = "Is Primary broker",
               example = "true/false"
           )
       public boolean isPrimary;
       @ApiModelProperty(
           name = "namespaceRegex",
           value = "The namespace-isolation policies attached to this broker"
       )
       public List<String> namespaceRegex;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to