sijie commented on a change in pull request #7533:
URL: https://github.com/apache/pulsar/pull/7533#discussion_r522485482
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java
##########
@@ -37,8 +48,8 @@ public static PulsarStandaloneBuilder instance() {
return new PulsarStandaloneBuilder();
}
- public PulsarStandaloneBuilder withConfig(ServiceConfiguration config) {
Review comment:
I don't think we should remove a method. We need to keep backward
compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]