shustsud opened a new pull request #8554:
URL: https://github.com/apache/pulsar/pull/8554


   ### Motivation
   
   I don't think the following `--exclude-libs,ALL` are reflected in linker.
    
[CMakeLists.txt](https://github.com/apache/pulsar/blob/f8080f4eb690d751f1b07ca54c23e1cd7774473f/pulsar-client-cpp/CMakeLists.txt#L214)
   
   I think `--exclude-libs,ALL` needs to be set in `add_link_options`.
    
[add_link_options](https://cmake.org/cmake/help/latest/command/add_link_options.html)
   
   `add_link_options` can be used from v3.13.
   Therefore, fixed(reverted) `add_compile_options` to 
`set`.([#4071](https://github.com/apache/pulsar/pull/4071))
   
   ### Modifications
   
   * Fixed CMakeLists.txt.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to