codelipenghui commented on pull request #8568:
URL: https://github.com/apache/pulsar/pull/8568#issuecomment-727671704


   > Remove the check for messages distribution, it's a broker's thing and has 
been tested in Java client test KeySharedSubscriptionTest. Instead, it checks 
the total number of received messages.
   
   @BewareMyPower I think we also should try the message distribution for CPP 
clients. I would rather think of it should be an integration test, we should 
ensure that the correctness of the client's behavior does not rely on 
server-side testing. If the current method causes frequently test instability, 
I think we can create an issue to find more effective testing methods and merge 
this PR first.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to