lhotari commented on pull request #8581: URL: https://github.com/apache/pulsar/pull/8581#issuecomment-728681953
> Is there any way to add a test case? > This is security related code > We should prevent regressions Yes. It would be possible to create a negative test case where the client and server are configured to use different TLS protocols. In that case, the TLS handshake shouldn't succeed and the connection shouldn't get established. That would catch the bug that was in the code. In addition, there could be a few tests that check that connections can be established when the server contains at least one of the protocols that is enabled on the client. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
