wuYin commented on a change in pull request #394:
URL: https://github.com/apache/pulsar-client-go/pull/394#discussion_r528009532



##########
File path: pulsar/producer.go
##########
@@ -76,6 +76,15 @@ type ProducerOptions struct {
        // This properties will be visible in the topic stats
        Properties map[string]string
 
+       // SendTimeout set the timeout for a message that not be acknowledged 
by server since sent.
+       // Send and SendAsync returns an error after timeout.
+       // Default is 30 seconds, -1 to disable.
+       SendTimeout time.Duration
+
+       // NonBlockIfQueueFull control whether Send and SendAsync block if 
producer's message queue is full.
+       // Default is false, if set to true then Send and SendAsync return 
error when queue is full.
+       NonBlockIfQueueFull bool

Review comment:
       Thanks for review.
   Now I renamed `NonBlockIfQueueFull` to `DisableBlockIfQueueFull`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to