BewareMyPower commented on pull request #8606: URL: https://github.com/apache/pulsar/pull/8606#issuecomment-731595313
Could you explain why the last message id should not be removed? See https://github.com/apache/pulsar/blob/281163b26f3b842c0834ff46b481453cddea7860/pulsar-client-cpp/lib/ConsumerImpl.cc#L851-L854 After message ids which is **<=** `messageId` are removed, the `messageId` would be added to `ackGroupingTrackerPtr_` to mark it as an acknowledged message though it's a pending state. And see Java client's implementation: https://github.com/apache/pulsar/blob/281163b26f3b842c0834ff46b481453cddea7860/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L784-L786 https://github.com/apache/pulsar/blob/281163b26f3b842c0834ff46b481453cddea7860/pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageTracker.java#L225-L239 The behaviors of Java and C++ client are the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
