milos-matijasevic commented on issue #389: URL: https://github.com/apache/pulsar-client-go/issues/389#issuecomment-743996526
Thanks @hrsakai for working on this! Did you try to reproduce scenario 1, if a connection to a broker is closed, a consumer will continue to read messages from the queue, if the size of the queue is more than 1 (which we can say can be good behavior) however it won't block on ack call. So now when you fixed this, after reconnecting it will start reading unacked messages which the program expects to be acked. Should that be handled somehow, on ack call if a connection is closed, a consumer should block, or somehow buffer acks not only to return, described here https://github.com/apache/pulsar-client-go/issues/389#issue-741736720, those acks then won't be sent to the broker. Or maybe I'm missing something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
