BewareMyPower commented on pull request #8913:
URL: https://github.com/apache/pulsar/pull/8913#issuecomment-745012903


   You should use clang-format 5.0 to reformat your code.
   
   ```diff
   diff --git a/pulsar-client-cpp/perf/PerfConsumer.cc 
b/pulsar-client-cpp/perf/PerfConsumer.cc
   index 7f2deb78792..6717fdeb827 100644
   --- a/pulsar-client-cpp/perf/PerfConsumer.cc
   +++ b/pulsar-client-cpp/perf/PerfConsumer.cc
   @@ -301,7 +301,7 @@ int main(int argc, char** argv) {
             "Number of listener threads")  //
    
            ("pool-connections", 
po::value<bool>(&args.poolConnections)->default_value(false),
   -         "whether pool connections used")   //
   +         "whether pool connections used")  //
    
            ("encryption-key-name,k", 
po::value<std::string>(&args.encKeyName)->default_value(""),
             "The private key name to decrypt payload")  //
   diff --git a/pulsar-client-cpp/perf/PerfProducer.cc 
b/pulsar-client-cpp/perf/PerfProducer.cc
   index ffc365dde7f..6e71ce78b1c 100644
   --- a/pulsar-client-cpp/perf/PerfProducer.cc
   +++ b/pulsar-client-cpp/perf/PerfProducer.cc
   @@ -279,9 +279,8 @@ int main(int argc, char** argv) {
             
po::value<long>(&args.batchingMaxPublishDelayMs)->default_value(3000),
             "Use only is batch-size > 1, Default is 3 seconds")  //
    
   -        ("pool-connections",
   -         po::value<bool>(&args.poolConnections)->default_value(false),
   -         "whether pool connections used")   //
   +        ("pool-connections", 
po::value<bool>(&args.poolConnections)->default_value(false),
   +         "whether pool connections used")  //
    
            ("encryption-key-name,k", 
po::value<std::string>(&args.encKeyName)->default_value(""),
             "The public key name to encrypt payload")  //
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to