jbampton commented on a change in pull request #8961:
URL: https://github.com/apache/pulsar/pull/8961#discussion_r543390591
##########
File path:
pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -134,6 +141,11 @@ private ZooKeeperCache getAndSetZkCache(Configuration
conf) {
public PlacementResult<List<BookieId>> newEnsemble(int ensembleSize, int
writeQuorumSize, int ackQuorumSize,
Map<String, byte[]> customMetadata, Set<BookieId> excludeBookies)
throws BKNotEnoughBookiesException {
+ // parse the ensemble placement policy from the custom metadata, if it
present, we will apply it to
Review comment:
```suggestion
// parse the ensemble placement policy from the custom metadata, if
it's present, we will apply it to
```
##########
File path:
pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -147,6 +159,11 @@ private ZooKeeperCache getAndSetZkCache(Configuration
conf) {
Map<String, byte[]> customMetadata, List<BookieId> currentEnsemble,
BookieId bookieToReplace, Set<BookieId> excludeBookies)
throws BKNotEnoughBookiesException {
+ // parse the ensemble placement policy from the custom metadata, if it
present, we will apply it to
Review comment:
```suggestion
// parse the ensemble placement policy from the custom metadata, if
it's present, we will apply it to
```
##########
File path:
pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -147,6 +159,11 @@ private ZooKeeperCache getAndSetZkCache(Configuration
conf) {
Map<String, byte[]> customMetadata, List<BookieId> currentEnsemble,
BookieId bookieToReplace, Set<BookieId> excludeBookies)
throws BKNotEnoughBookiesException {
+ // parse the ensemble placement policy from the custom metadata, if it
present, we will apply it to
+ // the isolation groups for filter the bookies.
Review comment:
```suggestion
// the isolation groups for filtering the bookies.
```
##########
File path:
pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -134,6 +141,11 @@ private ZooKeeperCache getAndSetZkCache(Configuration
conf) {
public PlacementResult<List<BookieId>> newEnsemble(int ensembleSize, int
writeQuorumSize, int ackQuorumSize,
Map<String, byte[]> customMetadata, Set<BookieId> excludeBookies)
throws BKNotEnoughBookiesException {
+ // parse the ensemble placement policy from the custom metadata, if it
present, we will apply it to
+ // the isolation groups for filter the bookies.
Review comment:
```suggestion
// the isolation groups for filtering the bookies.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
