BewareMyPower commented on issue #9028: URL: https://github.com/apache/pulsar/issues/9028#issuecomment-750312066
@codelipenghui I agree with @saosir , the point is that should Java client's implementation also have the problem? See https://github.com/apache/pulsar/blob/c17253b3b43c36250ba106dd7a17f35f64f546e5/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java#L101 https://github.com/apache/pulsar/blob/c17253b3b43c36250ba106dd7a17f35f64f546e5/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L134 Both `ConsumerImpl` and `MultiTopicsConsumerImpl` hold an `UnAckedMessageTracker`, when the tracker's timeout exceeds, it will trigger the redelivery. IMO, the `unAckedMessageTracker` of `MultiTopicsConsumerImpl` is redundant. And this feature of C++ client is ported from Java client. So I think if C++ client needs changes, Java client also needs changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
