sijie commented on a change in pull request #8946:
URL: https://github.com/apache/pulsar/pull/8946#discussion_r548196669
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -515,9 +515,4 @@ void asyncSetProperties(Map<String, String> properties,
final AsyncCallbacks.Upd
* @param promise
*/
void trimConsumedLedgersInBackground(CompletableFuture<?> promise);
-
- /**
- * Roll current ledger if it is full
- */
- void rollCurrentLedgerIfFull();
Review comment:
@hangc0276 we shouldn't remove a method from an interface directly. we
should keep the method and mark it as deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
