saosir edited a comment on pull request #9072:
URL: https://github.com/apache/pulsar/pull/9072#issuecomment-751923349


   Is it necessary to reset the batchIndex of `MessageId` when tracking a 
message . Because only the ack of the last message in batchMessage will be 
removed from `UnAckedMessageTrackerEnabled` 
   
   
https://github.com/apache/pulsar/blob/b09c0d7ef077c9f284023d5213f4d16f8847550c/pulsar-client-cpp/lib/ConsumerImpl.cc#L808-L817
   
   But the param `msgId` of add `UnAckedMessageTrackerEnabled#add` and 
`UnAckedMessageTrackerEnabled#remove` may contain batchIndex
   
   
https://github.com/apache/pulsar/blob/b09c0d7ef077c9f284023d5213f4d16f8847550c/pulsar-client-cpp/lib/UnAckedMessageTrackerEnabled.cc#L93-L102
   
   
https://github.com/apache/pulsar/blob/b09c0d7ef077c9f284023d5213f4d16f8847550c/pulsar-client-cpp/lib/UnAckedMessageTrackerEnabled.cc#L109-L118
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to