BewareMyPower commented on a change in pull request #9074:
URL: https://github.com/apache/pulsar/pull/9074#discussion_r549653887
##########
File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc
##########
@@ -1323,7 +1324,14 @@ TEST(BasicEndToEndTest, testRSAEncryption) {
std::string subName = "my-sub-name";
Producer producer;
- std::shared_ptr<EncKeyReader> keyReader = std::make_shared<EncKeyReader>();
+ std::string PUBLIC_CERT_FILE_PATH =
Review comment:
Should `EncKeyReader` in `testEncryptionFailure` also be replaced with
the default crypto key reader? Then the implementation of `EncKeyReader` could
be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
