michaeljmarshall commented on pull request #8796: URL: https://github.com/apache/pulsar/pull/8796#issuecomment-753227507
This latest commit includes a fix to make the pulsar python client available to the `root` and the `pulsar` user. This is necessary for pulsar functions and was exposed by the pulsar function integration tests, which currently run as the root user in the `pulsar-test-latest-version` docker container (this image defaults to run as root). I think we should convert the pulsar function tests to run as the `pulsar` user. I'll look at adding that to a later commit. These test failures (related to problems running as root vs pulsar) raise an important question about backwards compatibility and the published docker images. I think it adds value to let the container run as either the root user or the pulsar user to allow for end users to transition to the non-root version. As such, this commit installs the pulsar python client so that it's available to the root and pulsar. However, I don't think it is necessary to run tests as the root user because it is unlikely that the root user will have any other problems. Based on a limited understanding of the tests, the pulsar functions are likely one of the only processes that rely on python, making it the only process that use the pip dependencies. It'd be great to have some perspective from people more familiar with the project and any other edge cases in different deployments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
