[GitHub] [pulsar] codelipenghui commented on a change in pull request #9193: fix max topic for namespace does not work

[GitBox]

codelipenghui commented on a change in pull request #9193:
URL: https://github.com/apache/pulsar/pull/9193#discussion_r556221541



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
##########
@@ -812,7 +812,7 @@ protected boolean isNamespaceReplicated(NamespaceName 
namespaceName) {
         try {
             String topicPartitionPath = joinPath(MANAGED_LEDGER_PATH_ZNODE,
                     namespaceName.toString(), topicDomain.value());
-            List<String> topics = globalZk().getChildren(topicPartitionPath, 
false);
+            List<String> topics = localZk().getChildren(topicPartitionPath, 
false);

Review comment:
       Is it possible to add a unit test? This will make pulsar more robust




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org