codelipenghui opened a new pull request #9203:
URL: https://github.com/apache/pulsar/pull/9203


   ### Motivation
   
   Currently, for the HTTP async get method, we pass a callback and return a 
future. This is confusing which one is the right result. And if exception 
throws, will return a future that complete with exception but the callback have 
not been called. All the caller of the `asyncGetRequest` handles the callback, 
not the returned future, this will lead a potential hangs in the Pulsar Admin 
since the callback might never be called.
   
   ### Modifications
   
   Change the `asyncGetRequest` method to only handle the callback and use 
`void` as the return type.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to