congbobo184 commented on a change in pull request #9195:
URL: https://github.com/apache/pulsar/pull/9195#discussion_r557798206
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/InMemTransactionBuffer.java
##########
@@ -347,4 +347,19 @@ private void addTxnToTxnIdex(TxnID txnId, long
committedAtLedgerId) {
return CompletableFuture.completedFuture(null);
}
+ @Override
+ public boolean isTxnAborted(TxnID txnID) {
+ return false;
+ }
+
+ @Override
+ public void syncMaxReadPositionForNormalPublish(PositionImpl position) {
+ //no-op
+ }
+
+ @Override
+ public PositionImpl getMaxReadPosition() {
+ return PositionImpl.latest;
Review comment:
in-memory didn't need stable position logical, I don't change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
