Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r557915567
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -1685,6 +1686,20 @@ void asyncReadEntries(OpReadEntry opReadEntry) {
return getLedgerHandle(ledgerId).thenApply(rh ->
rh.getLedgerMetadata().toSafeString());
}
+ @Override
+ public CompletableFuture<LedgerInfo> getClosedLedgerInfo(long ledgerId)
throws ManagedLedgerException {
+ final LedgerInfo ledgerInfo = ledgers.get(ledgerId);
+ if (ledgerInfo == null) {
+ throw new ManagedLedgerException(
+ Strings.lenientFormat("ledger with id %s not found",
ledgerId));
+ } else if (ledgerInfo.getSize() == 0 || ledgerInfo.getEntries() == 0) {
Review comment:
> What happens if the ledger is closed with zero entries?
It will be deleted from metadata, see
https://github.com/apache/pulsar/blob/d3a6a8c2744733d00e6dfa30c0cac2f06eb1386a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L1535-L1547
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
