ltamber commented on a change in pull request #9219:
URL: https://github.com/apache/pulsar/pull/9219#discussion_r559345248
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
##########
@@ -169,12 +170,7 @@ public Consumer(Subscription subscription, SubType
subType, String topicName, lo
stats.setClientVersion(cnx.getClientVersion());
stats.metadata = this.metadata;
- if (Subscription.isIndividualAckMode(subType)) {
- this.pendingAcks = new ConcurrentLongLongPairHashMap(256, 1);
- } else {
- // We don't need to keep track of pending acks if the subscription
is not shared
- this.pendingAcks = null;
- }
+ this.pendingAcks = new ConcurrentLongLongPairHashMap(256, 1);
}
Review comment:
we need to track of pending acks in all subscription mode, I thinks this
is also need to create a hashmap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
