eolivelli commented on a change in pull request #9225:
URL: https://github.com/apache/pulsar/pull/9225#discussion_r560065180
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1604,7 +1604,15 @@ void setDelayedDeliveryPolicy(String topic
* @throws PulsarAdminException
* Unexpected error
*/
- int getMessageTTL(String topic) throws PulsarAdminException;
+ Integer getMessageTTL(String topic) throws PulsarAdminException;
Review comment:
We must pay more attention to public APIs, this kind of changes will
hurt users, probably someone will get an unexpected NPE
I would accept to change the signature for a 2.8. release, but please do not
cherry pick this change to 2.7 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
