Renkai commented on a change in pull request #9096:
URL: https://github.com/apache/pulsar/pull/9096#discussion_r560192398
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/OffloadIndexBlockBuilder.java
##########
@@ -71,7 +71,7 @@
/**
* Construct OffloadIndex from an InputStream.
*/
- OffloadIndexBlock fromStream(InputStream is) throws IOException;
+ OffloadIndexBlock indexFromStream(InputStream is) throws IOException;
Review comment:
Because now we have two different method with similar behavior, it's
better to have a distinguish
```
@Override
public OffloadIndexBlock indexFromStream(InputStream is) throws
IOException {
return OffloadIndexBlockImpl.get(is);
}
@Override
public StreamingOffloadIndexBlock streamingIndexFromStream(InputStream
is) throws IOException {
return StreamingOffloadIndexBlockImpl.get(is);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
