eolivelli commented on a change in pull request #9222:
URL: https://github.com/apache/pulsar/pull/9222#discussion_r560739832



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -2547,7 +2547,7 @@ private void checkTopicLevelPolicyEnable() {
             if (maxTopicsPerNamespace > 0) {
                 String partitionedTopicPath = 
PulsarWebResource.joinPath(MANAGED_LEDGER_PATH_ZNODE,
                         topicName.getNamespace(), 
topicName.getDomain().value());
-                List<String> topics = 
pulsar().getGlobalZkCache().getZooKeeper()
+                List<String> topics = pulsar().getLocalZkCache().getZooKeeper()

Review comment:
       the same here

##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
##########
@@ -1147,7 +1147,7 @@ public ServiceUnitId getServiceUnitId(TopicName 
topicName) throws Exception {
             LOG.debug("Getting children from partitioned-topics now: {}", 
path);
         }
 
-        return pulsar.getLocalZkCache().getChildrenAsync(path, 
null).thenCompose(topics -> {
+        return pulsar.getGlobalZkCache().getChildrenAsync(path, 
null).thenCompose(topics -> {

Review comment:
       this change does not affect only tests and the title of the issue may 
suggest.
   I see that in the description you cited a partial fix for a bug
   can you please reflect this in the title and state it more clearly in the 
description ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to