lhotari commented on a change in pull request #9258:
URL: https://github.com/apache/pulsar/pull/9258#discussion_r561727574
##########
File path:
pulsar-discovery-service/src/test/java/org/apache/pulsar/discovery/service/DiscoveryServiceTest.java
##########
@@ -245,6 +248,9 @@ private void addBrokerToZk(int number) throws Exception {
ZooKeeperChildrenCache availableBrokersCache =
(ZooKeeperChildrenCache) field
.get(service.getDiscoveryProvider().localZkCache);
availableBrokersCache.reloadCache(LOADBALANCE_BROKERS_ROOT);
+
+ Awaitility.await().atMost(10, TimeUnit.SECONDS).until(()
Review comment:
I've been wondering if we should get rid of `.atMost(10,
TimeUnit.SECONDS)` parts and simply rely on the [the Awaitility
defaults](https://github.com/awaitility/awaitility/wiki/Usage#defaults). The
default value for atMost is 10 seconds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
