zymap commented on a change in pull request #9272:
URL: https://github.com/apache/pulsar/pull/9272#discussion_r562394751
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -2420,6 +2421,10 @@ public boolean isAllowAutoTopicCreation(final String
topic) {
}
public boolean isAllowAutoTopicCreation(final TopicName topicName) {
+ //System topic can always be created automatically
+ if
(EventsTopicNames.NAMESPACE_EVENTS_LOCAL_NAME.equals(topicName.getLocalName()))
{
Review comment:
It should be created automatically when enabling the system topic?
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -2420,6 +2421,10 @@ public boolean isAllowAutoTopicCreation(final String
topic) {
}
public boolean isAllowAutoTopicCreation(final TopicName topicName) {
+ //System topic can always be created automatically
+ if
(EventsTopicNames.NAMESPACE_EVENTS_LOCAL_NAME.equals(topicName.getLocalName()))
{
Review comment:
I think it should be created automatically when enabling the system
topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
