MarvinCai commented on a change in pull request #9302:
URL: https://github.com/apache/pulsar/pull/9302#discussion_r563418250
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -764,10 +766,11 @@ default void delete(String topic, boolean force) throws
PulsarAdminException {
* @throws PulsarAdminException
* Unexpected error
*/
- TopicStats getStats(String topic, boolean getPreciseBacklog) throws
PulsarAdminException;
+ TopicStats getStats(String topic, boolean getPreciseBacklog,
Review comment:
@zymap
From what I've seen, this is only used by Admin CLI
([CmdTopics.java](https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java#L483-L490)),
which provides default value <false>. for all needed parameters, e.g.
getPreciseBacklog and subscriptionBacklogSize. And there's another default
implementation of [TopicStats getStats(String
topic)](https://github.com/apache/pulsar/blob/master/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java#L769-L771)
which is used in some other places, it also has default value <false> provided
for getPreciseBacklog and subscriptionBacklogSize.
So it shouldn't create compatibility issue for users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
