freeznet commented on a change in pull request #9246:
URL: https://github.com/apache/pulsar/pull/9246#discussion_r563733287
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java
##########
@@ -355,6 +357,14 @@
args.add("--pulsar_serviceurl");
args.add(pulsarServiceUrl);
+ if (instanceConfig.getFunctionDetails().getRuntime() ==
Function.FunctionDetails.Runtime.JAVA) {
+ // TODO: for now only Java function context exposed pulsar admin,
so python/go no need to pass this argument
+ // until pulsar admin client enabled in python/go function context.
+ if (pulsarWebServiceUrl != null) {
Review comment:
I agree, flag added, also add some tests when
`exposePulsarAdminClientEnabled=false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
