merlimat commented on a change in pull request #9292:
URL: https://github.com/apache/pulsar/pull/9292#discussion_r564069594
##########
File path: managed-ledger/src/main/proto/MLDataFormats.proto
##########
@@ -71,6 +71,9 @@ message PositionInfo {
// Store which index in the batch message has been deleted
repeated BatchedEntryDeletionIndexInfo batchedEntryDeletionIndexInfo = 5;
+
+ // serialized individualDeletedMessages
+ optional bytes serializedIndividualDeletedMessages = 6;
Review comment:
My main concern here is that we're mixing 2 serialization systems
together and therefore we need to pay attention when there are changes to that
format. That and that Java serialization is really bad in general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
