jerrypeng commented on a change in pull request #9275:
URL: https://github.com/apache/pulsar/pull/9275#discussion_r563441114
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerUtils.java
##########
@@ -343,4 +349,47 @@ public static boolean
isFunctionCodeBuiltin(Function.FunctionDetailsOrBuilder fu
.startMessageId(startMessageId)
.create();
}
+
+ public static Producer<byte[]>
createExclusiveProducerWithRetry(PulsarClient client,
+ String
topic,
+ String
producerName) {
+ Actions.Action createProducerAction = Actions.Action.builder()
+ .actionName(String.format("Creating exclusive producer for
topic %s", topic))
+ .numRetries(5)
+ .sleepBetweenInvocationsMs(10000)
+ .supplier(() -> {
+ try {
+ Producer<byte[]> producer =
client.newProducer().topic(topic)
+ .accessMode(ProducerAccessMode.Exclusive)
Review comment:
I don't think it is a good idea for "liveness" is we block forever which
may cause deadlocks. While blocking, the worker might be not even be the
leader anymore. I think we should keep retrying and periodically check if we
are still the leader.
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerUtils.java
##########
@@ -343,4 +349,47 @@ public static boolean
isFunctionCodeBuiltin(Function.FunctionDetailsOrBuilder fu
.startMessageId(startMessageId)
.create();
}
+
+ public static Producer<byte[]>
createExclusiveProducerWithRetry(PulsarClient client,
+ String
topic,
+ String
producerName) {
+ Actions.Action createProducerAction = Actions.Action.builder()
+ .actionName(String.format("Creating exclusive producer for
topic %s", topic))
+ .numRetries(5)
+ .sleepBetweenInvocationsMs(10000)
+ .supplier(() -> {
+ try {
+ Producer<byte[]> producer =
client.newProducer().topic(topic)
+ .accessMode(ProducerAccessMode.Exclusive)
+ .enableBatching(false)
Review comment:
I do not. We could enable it but I wouldn't expect much benefit as we
are not exactly optimizing for metadata operation throughput. For debugging it
is a little easier without batching as you will know exactly how many messages
are in the internal topics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
