zymap commented on a change in pull request #9318:
URL: https://github.com/apache/pulsar/pull/9318#discussion_r564275220
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java
##########
@@ -119,7 +119,8 @@
public static List<String> getGoInstanceCmd(InstanceConfig instanceConfig,
String originalCodeFileName,
String pulsarServiceUrl,
- boolean k8sRuntime) throws
IOException {
+ boolean k8sRuntime,
+ int metricsPort) throws
IOException {
Review comment:
Why not introduce the new configuration in the `InstanceConfig`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
