eolivelli commented on a change in pull request #9308:
URL: https://github.com/apache/pulsar/pull/9308#discussion_r564319390
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -175,6 +175,7 @@
@Setter(AccessLevel.PROTECTED)
public class BrokerService implements Closeable,
ZooKeeperCacheListener<Policies> {
private static final Logger log =
LoggerFactory.getLogger(BrokerService.class);
+ private static final int CHANNEL_CLOSE_TIMEOUT_SECONDS = 10;
Review comment:
+1 for @sijie's proposal
in production the process should exit as soon as possible, when the process
exists network resources are released
probably we can leave a little timeout by default (like 2 seconds) and set
it to 10s in tests (if it is really needed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
