lhotari commented on a change in pull request #9357:
URL: https://github.com/apache/pulsar/pull/9357#discussion_r566088345
##########
File path: .github/workflows/ci-build-macos.yaml
##########
@@ -39,6 +39,13 @@ jobs:
timeout-minutes: 120
steps:
+ - name: cancle previours runs
+ uses:
apache/airflow-cancel-workflow-runs@953e057dc81d3458935a18d1184c386b0f6b5738
+ with:
+ cancelMode: allDuplicates
Review comment:
Based on the [documentation of
apache/airflow-cancel-workflow-runs](https://github.com/apache/airflow-cancel-workflow-runs#inputs-and-outputs),
I'd assume that this should be `duplicates` instead of `allDuplicates`.
Since `duplicates` is the default value, the `cancelMode` parameter can be
omitted.
##########
File path: .github/workflows/ci-cpp.yaml
##########
@@ -37,6 +37,13 @@ jobs:
timeout-minutes: 120
steps:
+ - name: cancle previours runs
+ uses:
apache/airflow-cancel-workflow-runs@953e057dc81d3458935a18d1184c386b0f6b5738
+ with:
+ cancelMode: allDuplicates
+ token: ${{ secrets.GITHUB_TOKEN }}
+ sourceRunId: ${{ github.event.workflow_run.id }}
Review comment:
previous comments apply to all cancelMode and sourceRunId parameters
##########
File path: .github/workflows/ci-build-macos.yaml
##########
@@ -39,6 +39,13 @@ jobs:
timeout-minutes: 120
steps:
+ - name: cancle previours runs
+ uses:
apache/airflow-cancel-workflow-runs@953e057dc81d3458935a18d1184c386b0f6b5738
+ with:
+ cancelMode: allDuplicates
+ token: ${{ secrets.GITHUB_TOKEN }}
+ sourceRunId: ${{ github.event.workflow_run.id }}
Review comment:
`sourceRunId` should be omitted when used in the same workflow which
should be cancelled. [Documentation says about
sourceRunId](https://github.com/apache/airflow-cancel-workflow-runs#inputs-and-outputs):
"Useful only in workflow_run triggered events."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
