pkumar-singh commented on pull request #9348: URL: https://github.com/apache/pulsar/pull/9348#issuecomment-769354344
Yeah other tests certainly use the method `deregisterFunction`. But for tests `worker().getStateStoreAdminClient()` I think is null. ( I will confirm again). Therefore it never executed table deletion code before. And when I made the change Its again behind the same null check therefore it would not execute it now. `StorageAdminClient adminClient = worker().getStateStoreAdminClient();` I agree writing tests to cover these scenarios would be good. But that being said as far as test is concerned this PR does not have any bearing on existing tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
