rdhabalia commented on pull request #9292:
URL: https://github.com/apache/pulsar/pull/9292#issuecomment-769357085


   > what happens if I upgrade my broker to a new version and then I rollback 
to the previous version in case of problems ? IIUC we are going to write data 
that would not be understood by the old version. does it lead to some bad state 
of the system ? like having consumers that receive again the same messages ?
   
   no, it will not cause bad state in broker. broker understands both the 
format as it has separate buckets for each. broker recovers unack message 
ranges based on which ever bucket has ranges and later persist ranges in only 
new bucket. Broker rollback will not be able to recover unack messages from new 
bucket and in that case it will redeliver messages newer 
markDeleteMessageOffset.
   
   >  It is an improvement and doesn't solve all the problems.
   
   Yes, I shared my point of view in email regarding having unack message 
management. However, regardless abstraction changes, I think we can proceed 
with this PR as this can be used with existing default unack message 
implementation. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to