eolivelli commented on a change in pull request #9383:
URL: https://github.com/apache/pulsar/pull/9383#discussion_r567710042
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -369,8 +372,11 @@ public void reconsumeLaterCumulative(Message<?> message,
long delayTime, TimeUni
@Override
public CompletableFuture<Void> acknowledgeAsync(Messages<?> messages) {
try {
- messages.forEach(this::acknowledgeAsync);
- return CompletableFuture.completedFuture(null);
+ List<MessageId> messageIds = new ArrayList<>();
+ messages.forEach(message ->
messageIds.add(message.getMessageId()));
+ CompletableFuture<Void> completableFuture =
acknowledgeAsync(messageIds);
Review comment:
nit: you can save declaring this variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
