hnail commented on pull request #9388: URL: https://github.com/apache/pulsar/pull/9388#issuecomment-771461123
> > > #8422 has solve this problem, so this PR only add the test > > > > > > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ? > > Yes, it lack integration test. If you want to add the test, i will close this PR. > > > #8422 has solve this problem, so this PR only add the test > > > > > > I added `TestPulsarRecordCursor#TestKeyValueStructSchema` and `TestPulsarRecordCursor#TestKeyValuePrimitiveSchema ` in #8422 , which contains `KeyValueEncodingType.INLINE` and `KeyValueEncodingType.SEPARATED` modes unit test , but lack of integration test ? > > Yes, it lack integration test. If you want to add the test, i will close this PR. thanks replay , I'm not working the integration tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
