sijie commented on a change in pull request #9401:
URL: https://github.com/apache/pulsar/pull/9401#discussion_r568252103
##########
File path: conf/broker.conf
##########
@@ -185,6 +185,9 @@ subscriptionRedeliveryTrackerEnabled=true
# How frequently to proactively check and purge expired subscription
subscriptionExpiryCheckIntervalInMinutes=5
+# Enable Shared subscription (default is enabled)
+subscriptionSharedEnable=true
Review comment:
Instead of introducing a flag, we should introduce a general setting
like `subscriptionTypesEnabled`. If `subscriptionTypesEnabled` is not set, it
supports all subscription types. Otherwise, the subscription types that are not
on that list will be disabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
