jerrypeng commented on a change in pull request #9237:
URL: https://github.com/apache/pulsar/pull/9237#discussion_r569049716
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
##########
@@ -754,17 +721,19 @@ public void updateFunctionOnWorkerLeader(final String
tenant,
else{
clsLoader = FunctionConfigUtils.validate(functionConfig,
componentPackageFile);
}
- return FunctionConfigUtils.convert(functionConfig, clsLoader);
-
- }
-
- private static boolean hasPackageTypePrefix(String destPkgUrl) {
- return Arrays.stream(PackageType.values()).anyMatch(type ->
destPkgUrl.startsWith(type.toString()));
+ return clsLoader;
}
- private File downloadPackageFile(String packageName) throws IOException,
PulsarAdminException {
- File file = Files.createTempFile("function", ".tmp").toFile();
- worker().getBrokerAdmin().packages().download(packageName,
file.toString());
- return file;
+ private ImmutablePair<String, String> getTypeClassName(String
functionPackageUrl) {
+ try {
+ Map<String, String> properties =
worker().getBrokerAdmin().packages()
Review comment:
I don't understand what we are doing here. We are not using pulsar
admin to upload packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
