BewareMyPower commented on pull request #9493:
URL: https://github.com/apache/pulsar/pull/9493#issuecomment-773995915
Good job! But I have a question, can you reproduce this scenario in KoP's
test? I found currently KoP tests enabled both two
`BrokerEntryMetadataInterceptor`s while the
`AppendBrokerTimestampMetadataInterceptor` is not necessary. However, after I
removed the interceptor as followed
```java
public static void
addBrokerEntryMetadataInterceptors(ServiceConfiguration configuration) {
Set<String> interceptorNames = new HashSet<>();
//interceptorNames.add("org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor");
interceptorNames.add("org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor");
configuration.setBrokerEntryMetadataInterceptors(interceptorNames);
}
```
The KoP tests still passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
