congbobo184 commented on a change in pull request #9490:
URL: https://github.com/apache/pulsar/pull/9490#discussion_r571590712
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -2529,6 +2534,19 @@ public void publishTxnMessage(TxnID txnID, ByteBuf
headersAndPayload, PublishCon
return;
}
+ // need to check transaction buffer ready before before check the
message deduplication
+ if (transactionBuffer instanceof TopicTransactionBuffer) {
+ if (!((TopicTransactionBuffer) transactionBuffer).checkIfReady()) {
+ if (log.isDebugEnabled()) {
+ log.debug("[{}]Transaction buffer not recover complete!",
topic);
+ }
+ publishContext.completed(new BrokerServiceException
+ .ServiceUnitNotReadyException("[{" + topic +
"}]Transaction buffer not "
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
