315157973 commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r572092410
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -1170,7 +1170,7 @@ $ pulsar-admin namespaces set-message-ttl
tenant/namespace options
Options
|Flag|Description|Default|
|----|---|---|
-|`-ttl`, `--messageTTL`|Message TTL in seconds. When the value is set to `0`,
TTL is disabled. TTL is disabled by default. |0|
+|`-ttl`, `--messageTTL`|Message TTL in seconds|3600s|
Review comment:
It seems that there are many places to confirm according to the code.
The default value here should be 0 (disabled),because the default values of
topic and namespace-level are both null (not set)
we can see the broker-level default value in broker.conf
(ttlDurationDefaultInSeconds)
namespace-level default value in
`pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/Policies.java`
topic-level default in
`pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java`
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
Same here
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Review comment:
In order to make topic-level and namespace-level consistent, these
commands have been deprecated. See CmdTopics#CmdTopics for details.
The deprecated commands are in CmdTopics#initDeprecatedCommands
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
