lhotari commented on pull request #9393: URL: https://github.com/apache/pulsar/pull/9393#issuecomment-775365369
> I plan to take a look at the `LinuxBrokerHostUsageImpl` class later. I wonder if there is a bug in that code because we saw that `Infinity` value for CPU usage in the logs above. I'm guessing we're dividing by 0 in some rare edge case. @michaeljmarshall very good direction. One detail that immediately caught my eye in `LinuxBrokerHostUsageImpl` is the usage of `System.currentTimeMillis()`. Replacing that with `System.nanoTime()` could be helpful. The calculations that mix doubles and longs seem error prone. It would be useful to check how good the test coverage for this class is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
