freeznet commented on pull request #9513:
URL: https://github.com/apache/pulsar/pull/9513#issuecomment-775649448


   Just as you said, all send failures are fatal, but this is limited within 
`goInstance`’s `producer`. For user who get `producer` from 
`context.outputMessage()`, it might different. Before this pr, function user 
will always get a new and ready-to-use producer, because if we create producer 
with error, function crush (I also don’t think this is the correct way, but 
should been raised up as another issue separately). So user dont have to worry 
wether the producer is closed or non-existed. but in this pr, for some reason, 
i assume that user will get a closed producer from cache, and when user try to 
send message from a closed or non-existed producer, which might have some 
additional issue, like function been blocked with closed producer. Or user self 
cannot managed to get a new producer if the cached one is closed. I m not sure 
if I was over considered this issue, so @sijie @wolfstudy PTAL if you have 
time, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to