merlimat commented on a change in pull request #9551:
URL: https://github.com/apache/pulsar/pull/9551#discussion_r573495082
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/EnsemblePlacementPolicyConfig.java
##########
@@ -30,6 +31,8 @@
private final Class policyClass;
private final Map<String, Object> properties;
+ private static ObjectMapper mapper = new ObjectMapper();
Review comment:
This is not thread safe and also is not used the preferred configuration
for Jackson. `pulsar-common` has already `ObjectMapperFactory.getThreadLocal()`
which is used for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
