lhotari commented on a change in pull request #9580:
URL: https://github.com/apache/pulsar/pull/9580#discussion_r575366933
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/stats/JvmDefaultGCMetricsLogger.java
##########
@@ -36,19 +40,46 @@
private volatile long accumulatedFullGcTime = 0;
private volatile long currentFullGcTime = 0;
- @SuppressWarnings("restriction")
- private static sun.management.HotspotRuntimeMBean runtime;
+ private static Object /*sun.management.HotspotRuntimeMBean*/ runtime;
+ private static Method getTotalSafepointTimeHandle;
Review comment:
nit: naming this `getTotalSafepointTimeMethod` instead of `*Handle`?
Since there's also
[java.lang.invoke.MethodHandle](https://docs.oracle.com/javase/8/docs/api/java/lang/invoke/MethodHandle.html)
which is different than `java.lang.reflect.Method`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
